Greptile Overview

sequenceDiagram
    participant Physics as PhysicsBehavior::onCollide
    participant Vehicle as Dead Vehicle Object
    participant Mine as Mine/Non-Building
    participant Weapon as WeaponStore
    participant Nearby as Nearby Units/Structures
    
    Note over Physics,Mine: Frame N: Vehicle collides with mine
    Physics->>Vehicle: Check if KINDOF_VEHICLE
    Physics->>Vehicle: Check if !isEffectivelyDead() [NEW]
    alt Vehicle is dead (before fix)
        Physics->>Weapon: createAndFireTempWeapon(VehicleCrashesIntoNonBuildingWeapon)
        Weapon->>Nearby: Deal damage
        Note over Physics,Nearby: Every frame collision persists
    else Vehicle is dead (after fix)
        Physics-->>Physics: Skip weapon firing
        Note over Physics: No damage dealt
    end
    
    Note over Physics,Mine: Frame N+1: Still colliding
    alt Before fix
        Physics->>Weapon: Fire weapon AGAIN
        Weapon->>Nearby: Deal damage AGAIN
        Note over Nearby: Continuous damage until mine destroyed
    else After fix
        Physics-->>Physics: Skip - vehicle is dead
    end

This doesn't properly resolve #2015, the issue with aircraft landing on mines is that the aircraftSlowDeathBehaviour module for the chinook is waiting to see when the unit hits the ground. But it never does and remains floating over the mines above the ground detection threshold.

The issue is that the mines block the slow death code from detecting when the chinook hits the ground properly and prevents the carcus from ever clearing itself.

This doesn't properly resolve #2015, the issue with aircraft landing on mines is that the aircraftSlowDeathBehaviour module for the chinook is waiting to see when the unit hits the ground. But it never does and remains floating over the mines above the ground detection threshold.

The issue is that the mines block the slow death code from detecting when the chinook hits the ground properly and prevents the carcus from ever clearing itself.

That sounds like a separate issue? This fix targets the issue as described; "GLA Technical kills/damages building when dying by China Mines".

This doesn't properly resolve #2015, the issue with aircraft landing on mines is that the aircraftSlowDeathBehaviour module for the chinook is waiting to see when the unit hits the ground. But it never does and remains floating over the mines above the ground detection threshold.
The issue is that the mines block the slow death code from detecting when the chinook hits the ground properly and prevents the carcus from ever clearing itself.

That sounds like a separate issue? This fix targets the issue as described; "GLA Technical kills/damages building when dying by China Mines".

Ah yeah, i glanced over it and read the bit about migs and chinooks in the issue as well.

The other week Fish and i were looking into the same issue but with aircraft and it is a problem with the death behaviour modules.

I don't think your change here will fix their behaviour since they are never properly set to being effectively dead since they remain stuck in their death crash handling.

I don't think your change here will fix their behaviour since they are never properly set to being effectively dead since they remain stuck in their death crash handling.

Is effectively dead not exactly the status that should apply here? As far as I'm aware that status is applied as soon as health becomes depleted.